lkft-android: add android boottime testcase #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuyq
force-pushed
the
android-upstream-boottime
branch
3 times, most recently
from
b22441e
to
260e8de
Compare
roxell
reviewed
Jul 20, 2023
| @@ -0,0 +1,24 @@ | |||
| {## NOTE: PLEASE DON'T ADD BLOCK HERE, WHICH DOES NOT WORK ##} | |||
There was a problem hiding this comment.
Not very helpful comment... please elaborate why it doesn't work
liuyq
force-pushed
the
android-upstream-boottime
branch
2 times, most recently
from
69461e8
to
87b10d2
Compare
so that it could be reused with different variables passed. But since there are some blocks defined inside the boot_target block, which could not be moved to the include file, so just most of the lines are moved to the include file, thus necessary lines like the "- boot:" line should be added as well when reused in other places. Signed-off-by: Yongqin Liu <[email protected]>
like the job here:
https://lkft.validation.linaro.org/scheduler/job/6601281
Signed-off-by: Yongqin Liu <[email protected]>
liuyq
force-pushed
the
android-upstream-boottime
branch
from
87b10d2
to
1899623
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
like the job here:
https://lkft.validation.linaro.org/scheduler/job/6601281